Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position view selection buttons on top #1816

Closed
janno42 opened this issue Oct 10, 2022 · 7 comments · Fixed by #2047
Closed

Position view selection buttons on top #1816

janno42 opened this issue Oct 10, 2022 · 7 comments · Fixed by #2047
Assignees
Labels
[C] Frontend Focuses on frontend implementation [P] Minor Minor priority

Comments

@janno42
Copy link
Member

janno42 commented Oct 10, 2022

The pages results_publication_detail and staff_evaluation_textanswers have buttons to select different views on the top right.
When evaluations have long names that span over more than one line, the buttons are vertically positioned in the middle of the evaluation name.
Instead, they should stay on the top of the page.

@janno42 janno42 added [C] Frontend Focuses on frontend implementation [P] Minor Minor priority [S] Very small This issue should require only very small changes. labels Oct 10, 2022
@florian-str florian-str removed their assignment Oct 24, 2022
@florian-str
Copy link
Collaborator

All sides where an input field of some sort is next to a textfield are effected by this issue.

@richardebeling richardebeling removed the [S] Very small This issue should require only very small changes. label Oct 24, 2022
@janno42
Copy link
Member Author

janno42 commented Nov 7, 2022

On a quick glance I found only one other occurrence on grades_semester_view. Did you find more?

@richardebeling
Copy link
Member

@janno42 The issue text above says results_publication_detail where it should be results_evaluation_detail, correct?

@fekoch
Copy link
Collaborator

fekoch commented Oct 16, 2023

Here are some Screenshots, I would like some input:

grades_semester_view:

Screenshots

Vorher:
Screen Shot 2023-10-16 at 20 52 57
Top-Aligned:
Screen Shot 2023-10-16 at 20 52 25

results_evaluation_details:

Screenshots

Top: ![image](https://github.com/e-valuation/EvaP/assets/45557700/a715dc88-cc83-4d87-b1d4-c5698b51efa1)

Bottom:
image

Center:
image

For grades_semester_view I personally think the centered version looks cleaner, but I am unsure.

For results_evaluation_details I would say that the bottom aligned version looks the best.

What do you think?

@fekoch
Copy link
Collaborator

fekoch commented Oct 16, 2023

Here also Screenshots for staff_evaluation_textanswers:

Screenshots

Top:

image

Bottom:

image

@janno42
Copy link
Member Author

janno42 commented Oct 23, 2023

Thanks for the screenshots! I prefer a consistent position. Looking at the examples, I'd say always placing the buttons at the bottom looks best. What do you think?

@richardebeling
Copy link
Member

Fixed in #2047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Frontend Focuses on frontend implementation [P] Minor Minor priority
Development

Successfully merging a pull request may close this issue.

4 participants