Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reposition View Selection Buttons #2047

Merged
merged 18 commits into from
Nov 6, 2023
Merged

Reposition View Selection Buttons #2047

merged 18 commits into from
Nov 6, 2023

Conversation

fekoch
Copy link
Collaborator

@fekoch fekoch commented Oct 23, 2023

richardebeling
richardebeling requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, thanks :)

evap/results/templates/results_evaluation_detail.html Outdated Show resolved Hide resolved
evap/results/templates/results_evaluation_detail.html Outdated Show resolved Hide resolved
evap/results/tests/test_views.py Outdated Show resolved Hide resolved
evap/results/tests/test_views.py Outdated Show resolved Hide resolved
evap/static/bootstrap Outdated Show resolved Hide resolved
@fekoch fekoch requested a review from richardebeling October 26, 2023 20:51
richardebeling
richardebeling approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

janno42
janno42 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

niklasmohrin
niklasmohrin approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@niklasmohrin niklasmohrin merged commit 7e1726a into e-valuation:main Nov 6, 2023
10 checks passed
@richardebeling richardebeling linked an issue Nov 13, 2023 that may be closed by this pull request
Position view selection buttons on top #1816
Closed
@richardebeling richardebeling mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Position view selection buttons on top
4 participants
@fekoch @janno42 @richardebeling @niklasmohrin