Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to builtin generic views where appropriate #1964

Merged
merged 39 commits into from
Oct 9, 2023
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ba37efd
work
niklasmohrin May 29, 2023
09f3f49
more work
niklasmohrin Jun 5, 2023
7ca0ad7
this one is controversial
niklasmohrin Jun 19, 2023
c6f9497
some nice generic views
niklasmohrin Jun 26, 2023
e7b6fa5
more views
niklasmohrin Jun 26, 2023
614d96d
yet another view
niklasmohrin Jun 26, 2023
d4e5536
make something atomic
niklasmohrin Jul 3, 2023
729316b
classic formview
niklasmohrin Jul 3, 2023
fe89322
staff degree and course type index
niklasmohrin Jul 3, 2023
8af1a6b
user create view
niklasmohrin Jul 3, 2023
1ebde2f
faq index
niklasmohrin Jul 3, 2023
c0a2b20
infotexts
niklasmohrin Jul 3, 2023
c202186
format
niklasmohrin Jul 10, 2023
117c289
create mixins for common stuff
niklasmohrin Jul 10, 2023
7d5e744
user merge selection
niklasmohrin Jul 10, 2023
62411e5
template edit
niklasmohrin Jul 10, 2023
8849da7
Remove unused `editor_required`
niklasmohrin Jul 24, 2023
08b7828
wrong way around
niklasmohrin Jul 24, 2023
9c80711
use `self.object` in `SemesterExportView`
niklasmohrin Jul 24, 2023
8e89e0c
Add renaming functionality to `FormsetView`
niklasmohrin Jul 31, 2023
69028e6
Check that forms redirect
niklasmohrin Jul 31, 2023
e7abaf2
Revert `UploadGradesView`
niklasmohrin Jul 31, 2023
6c73bac
Missed a rename
niklasmohrin Jul 31, 2023
bf73430
unused imports
niklasmohrin Jul 31, 2023
560c598
Don't save form if operation is invalid
niklasmohrin Jul 31, 2023
afe0796
empty commit
niklasmohrin Aug 21, 2023
823e1df
Add tests for `class_or_function_check_decorator`
niklasmohrin Aug 28, 2023
2ade9d5
Make it more linter friendly
niklasmohrin Aug 28, 2023
ebb8d34
Make linter more code friendly
niklasmohrin Aug 28, 2023
2af3830
yes
niklasmohrin Aug 28, 2023
8fae961
remove disable_if_archived stuff because we never render the disable …
niklasmohrin Oct 2, 2023
52f9b64
add comment to class_or_function_check_decorator
niklasmohrin Oct 2, 2023
6dfe419
revert port of `semester_export`
niklasmohrin Oct 2, 2023
f326956
document `FormsetView`
niklasmohrin Oct 2, 2023
140290a
document `SaveValidFormMixin`
niklasmohrin Oct 2, 2023
61cc4a7
fix semester export view reference in urls
niklasmohrin Oct 2, 2023
0e5cd94
remove comments on auth decorators
niklasmohrin Oct 2, 2023
230e5be
remove unused import
niklasmohrin Oct 2, 2023
489c0c7
test some uncovered lines
niklasmohrin Oct 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused editor_required
niklasmohrin committed Oct 2, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 8849da74a35fad823d7bc1d8b08399b63e327f7e
9 changes: 0 additions & 9 deletions evap/evaluation/auth.py
Original file line number Diff line number Diff line change
@@ -127,15 +127,6 @@ def editor_or_delegate_required(user):
return user.is_editor_or_delegate


@class_or_function_check_decorator
def editor_required(user):
"""
Decorator for views that checks that the user is logged in and has edit
right for at least one evaluation.
"""
return user.is_editor


@class_or_function_check_decorator
def participant_required(user):
"""