Fix Borders in Outlined Button Group in textanswers view #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janno42
reviewed
Jan 8, 2024
fekoch
force-pushed
the
i1945/fix-button-group-border-2
branch
2 times, most recently
from
c34c4ab to
2f27865
Compare
|
@richardebeling I tried it using the new firefox and could not reproduce the issue anymore. |
richardebeling
approved these changes
Jan 22, 2024
|
Just so we are on the same page: This is just a special case of #1945, right? Otherwise, we should link the PR and issue |
niklasmohrin
requested changes
Jan 22, 2024
fekoch
force-pushed
the
i1945/fix-button-group-border-2
branch
2 times, most recently
from
6b8fd89 to
9769815
Compare
|
@niklasmohrin I removed all unused CSS selectors. I also checked again, if the issue still occurs on main and I could still verify that there are double borders that happen on main but not on this branch. |
niklasmohrin
approved these changes
Jan 29, 2024
This class replaces bootstraps default strategy of using negative margins to hide double borders with specific css-selectors that hide and show specific borders.
fekoch
force-pushed
the
i1945/fix-button-group-border-2
branch
from
9769815 to
baa7fcc
Compare
richardebeling
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes double borders referenced here.
This needs the
:has()pseudoselector, which will be supported in the next firefox release 121 (planned release date: 2023-12-19)