Split settings.BASE_DIR into MODULE and DATADIR
#2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves some runtime generated outside the module path.
niklasmohrin
force-pushed
the
settings-basedir
branch
3 times, most recently
from
4841385 to
ea891e1
Compare
niklasmohrin
force-pushed
the
settings-basedir
branch
from
ea891e1 to
f32726c
Compare
|
@janno42 This could require small changes to the settings on production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #2328
The idea is that we don't want to place any files at runtime into
MODULE, as that might bevenv/lib/python3.10/site-packages/evap/, or a path into the Nix store or something similar.Best reviewed by commit.