Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-modal-submit attribute fails when an input tag is used instead of a button tag #4923

Closed
CaMer0n opened this issue Dec 14, 2022 · 0 comments
Labels
type: bug A problem that should not be happening
Milestone

Comments

@CaMer0n
Copy link
Member

CaMer0n commented Dec 14, 2022

Bug Description

The data-modal-submit attribute typically moves any submit button (with an id='etrigger-submit' ) out of the modal iframe window and into the modal footer. (as long as 'buttons-bar' container is used). However, it does not currently work on <input> submit buttons, only on <button> submit buttons.

How to Reproduce

Main page

<a href="admin_config.php?mode=main&action=custom" data-modal-submit="true">New Modal</a>

Modal Page:

echo "<div class='buttons-bar'>".$frm->submit('send','Send', ['id'=>'etrigger-submit'])."</div>";

Expected Behavior

The same behavior for both types of submit buttons.

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Dec 14, 2022
@CaMer0n CaMer0n added this to the e107 2.3.3 milestone Dec 14, 2022
CaMer0n added a commit that referenced this issue Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

1 participant