Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 105 reserve requirements #172

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Feat 105 reserve requirements #172

merged 5 commits into from
Jul 14, 2023

Conversation

Ethan-Russell
Copy link
Member

Added reserve requirements

@github-actions
Copy link

Benchmark result

Judge result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmarks:
    • Target: 11 Jul 2023 - 20:02
    • Baseline: 11 Jul 2023 - 20:05
  • Package commits:
    • Target: 283883
    • Baseline: b5f596
  • Julia commits:
    • Target: e4ee48
    • Baseline: e4ee48
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["get_af"] 1.16 (5%) ❌ 1.00 (1%)
["get_generator"] 1.09 (5%) ❌ 1.00 (1%)
["read_data"] 1.06 (5%) ❌ 1.02 (1%) ❌
["run_e4st"] 0.00 (5%) ✅ 0.02 (1%) ✅
["setup_model"] 1.09 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       5007 s          0 s        220 s        753 s          0 s
       #2  2793 MHz       1769 s          0 s        173 s       4008 s          0 s
  Memory: 6.7694854736328125 GB (4792.51953125 MB free)
  Uptime: 602.92 sec
  Load Avg:  1.17  1.16  0.71
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       6793 s          0 s        240 s        813 s          0 s
       #2  2793 MHz       1834 s          0 s        180 s       5798 s          0 s
  Memory: 6.7694854736328125 GB (4801.2890625 MB free)
  Uptime: 789.78 sec
  Load Avg:  1.0  1.08  0.77
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmark: 11 Jul 2023 - 20:2
  • Package commit: 283883
  • Julia commit: e4ee48
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["get_af"] 107.240 ns (5%) 32 bytes (1%) 2
["get_generator"] 56.477 ns (5%) 48 bytes (1%) 1
["get_plnom"] 123.392 ns (5%) 48 bytes (1%) 3
["read_data"] 44.324 ms (5%) 10.35 MiB (1%) 352258
["run_e4st"] 243.819 ms (5%) 8.853 ms 104.80 MiB (1%) 576941
["setup_model"] 1.837 s (5%) 656.262 ms 989.36 MiB (1%) 13350314

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       5007 s          0 s        220 s        753 s          0 s
       #2  2793 MHz       1769 s          0 s        173 s       4008 s          0 s
  Memory: 6.7694854736328125 GB (4792.51953125 MB free)
  Uptime: 602.92 sec
  Load Avg:  1.17  1.16  0.71
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmark: 11 Jul 2023 - 20:5
  • Package commit: b5f596
  • Julia commit: e4ee48
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["get_af"] 92.147 ns (5%) 32 bytes (1%) 2
["get_generator"] 51.917 ns (5%) 48 bytes (1%) 1
["get_plnom"] 121.695 ns (5%) 48 bytes (1%) 3
["read_data"] 41.632 ms (5%) 10.12 MiB (1%) 337233
["run_e4st"] 74.553 s (5%) 3.099 s 5.11 GiB (1%) 77893725
["setup_model"] 1.690 s (5%) 550.786 ms 989.36 MiB (1%) 13350314

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       6793 s          0 s        240 s        813 s          0 s
       #2  2793 MHz       1834 s          0 s        180 s       5798 s          0 s
  Memory: 6.7694854736328125 GB (4801.2890625 MB free)
  Uptime: 789.78 sec
  Load Avg:  1.0  1.08  0.77
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          2
On-line CPU(s) list:             0,1
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
CPU family:                      6
Model:                           106
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
Stepping:                        6
BogoMIPS:                        5586.87
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       96 KiB (2 instances)
L1i cache:                       64 KiB (2 instances)
L2 cache:                        2.5 MiB (2 instances)
L3 cache:                        48 MiB (1 instance)
NUMA node(s):                    1
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Vendor :Intel
Architecture :UnknownIntel
Model Family: 0x06, Model: 0x6a, Stepping: 0x06, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (48, 1280, 49152) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.87% and project coverage change: +0.18 🎉

Comparison is base (b5f5962) 89.18% compared to head (86de1c5) 89.36%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   89.18%   89.36%   +0.18%     
==========================================
  Files          46       47       +1     
  Lines        3993     4070      +77     
==========================================
+ Hits         3561     3637      +76     
- Misses        432      433       +1
Impacted Files Coverage Δ
src/E4ST.jl 87.95% <ø> (ø)
src/types/Unit.jl 100.00% <ø> (ø)
src/types/modifications/GenerationStandard.jl 96.73% <ø> (ø)
src/types/Crediting.jl 74.41% <78.57%> (+8.90%) ⬆️
src/types/modifications/ReserveRequirement.jl 98.38% <98.38%> (ø)
src/io/data.jl 90.00% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ethan-Russell
Copy link
Member Author

@Ethan-Russell Ethan-Russell linked an issue Jul 11, 2023 that may be closed by this pull request
Capacity Reserve Requirements #105
Closed
@github-actions
Copy link

Benchmark result

Judge result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmarks:
    • Target: 11 Jul 2023 - 20:40
    • Baseline: 11 Jul 2023 - 20:43
  • Package commits:
    • Target: c2f88f
    • Baseline: b5f596
  • Julia commits:
    • Target: e4ee48
    • Baseline: e4ee48
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["get_af"] 0.94 (5%) ✅ 1.00 (1%)
["read_data"] 1.02 (5%) 1.02 (1%) ❌
["run_e4st"] 0.00 (5%) ✅ 0.02 (1%) ✅
["setup_model"] 1.07 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       3506 s          0 s        179 s       2023 s          0 s
       #2  2793 MHz       3127 s          0 s        214 s       2352 s          0 s
  Memory: 6.7694854736328125 GB (4835.56640625 MB free)
  Uptime: 578.64 sec
  Load Avg:  1.01  1.08  0.67
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       3695 s          0 s        186 s       3645 s          0 s
       #2  2793 MHz       4746 s          0 s        232 s       2538 s          0 s
  Memory: 6.7694854736328125 GB (4878.7421875 MB free)
  Uptime: 761.09 sec
  Load Avg:  1.0  1.04  0.74
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmark: 11 Jul 2023 - 20:40
  • Package commit: c2f88f
  • Julia commit: e4ee48
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["get_af"] 92.823 ns (5%) 32 bytes (1%) 2
["get_generator"] 59.507 ns (5%) 48 bytes (1%) 1
["get_plnom"] 120.725 ns (5%) 48 bytes (1%) 3
["read_data"] 42.625 ms (5%) 10.35 MiB (1%) 352258
["run_e4st"] 240.353 ms (5%) 8.512 ms 104.79 MiB (1%) 576951
["setup_model"] 1.801 s (5%) 637.356 ms 989.36 MiB (1%) 13350314

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       3506 s          0 s        179 s       2023 s          0 s
       #2  2793 MHz       3127 s          0 s        214 s       2352 s          0 s
  Memory: 6.7694854736328125 GB (4835.56640625 MB free)
  Uptime: 578.64 sec
  Load Avg:  1.01  1.08  0.67
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/E4ST.jl/E4ST.jl

Job Properties

  • Time of benchmark: 11 Jul 2023 - 20:43
  • Package commit: b5f596
  • Julia commit: e4ee48
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["get_af"] 99.163 ns (5%) 32 bytes (1%) 2
["get_generator"] 57.760 ns (5%) 48 bytes (1%) 1
["get_plnom"] 119.299 ns (5%) 48 bytes (1%) 3
["read_data"] 41.603 ms (5%) 10.12 MiB (1%) 337233
["run_e4st"] 72.389 s (5%) 3.063 s 5.11 GiB (1%) 77895305
["setup_model"] 1.681 s (5%) 542.950 ms 989.36 MiB (1%) 13350314

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.2 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       3695 s          0 s        186 s       3645 s          0 s
       #2  2793 MHz       4746 s          0 s        232 s       2538 s          0 s
  Memory: 6.7694854736328125 GB (4878.7421875 MB free)
  Uptime: 761.09 sec
  Load Avg:  1.0  1.04  0.74
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          2
On-line CPU(s) list:             0,1
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
CPU family:                      6
Model:                           106
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
Stepping:                        6
BogoMIPS:                        5586.87
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       96 KiB (2 instances)
L1i cache:                       64 KiB (2 instances)
L2 cache:                        2.5 MiB (2 instances)
L3 cache:                        48 MiB (1 instance)
NUMA node(s):                    1
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Vendor :Intel
Architecture :UnknownIntel
Model Family: 0x06, Model: 0x6a, Stepping: 0x06, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (48, 1280, 49152) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@sallyrobson
Copy link
Member

@Ethan-Russell this looks good to me, if you're ready to merge it then you can go ahead and do that.

@Ethan-Russell
Copy link
Member Author

Great, merging now. Thanks for looking it over!

@Ethan-Russell Ethan-Russell merged commit bb96566 into main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capacity Reserve Requirements
2 participants
@Ethan-Russell @sallyrobson