Index crash long run for put #537
Conversation
| @@ -327,6 +332,7 @@ class BtreeNode : public sisl::ObjLifeCounter< BtreeNode > { | |||
| uint16_t level() const { return get_persistent_header_const()->level; } | |||
|
|
|||
| // uint32_t total_entries() const { return (has_valid_edge() ? total_entries() + 1 : total_entries()); } | |||
| uint64_t max_keys_in_node() const { return m_trans_hdr.max_keys_in_node; } | |||
There was a problem hiding this comment.
Should we wrap all these related codes/methods with #ifdef _PRERELEASE?
There was a problem hiding this comment.
not needed since it will be called only in prerelease.
| @@ -127,10 +246,18 @@ struct IndexCrashTest : public test_common::HSTestHelper, BtreeTestHelper< TestT | |||
| this->get_all(); | |||
| } | |||
|
|
|||
| void reset_btree() { | |||
| this->m_bt->destroy(); | |||
There was a problem hiding this comment.
Suggest calling remove_index_table for destroyed btree here
There was a problem hiding this comment.
Good catch. restart makes it erased. nontheless destoy is needed.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
===========================================
+ Coverage 56.51% 67.96% +11.45%
===========================================
Files 108 109 +1
Lines 10300 10433 +133
Branches 1402 1402
===========================================
+ Hits 5821 7091 +1270
+ Misses 3894 2674 -1220
- Partials 585 668 +83 ☔ View full report in Codecov by Sentry. |
No description provided.