Reset peer's log info once new connection is established #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To support offline data change (including snapshot installation), peer's log info should be reset if the previous connection is gone. Otherwise, there will be a data mismatch and the leader will attempt to send logs based on incorrect info. * The reset peer info will be recovered during the first `append_entries` communication between the leader and the peer.
sheepgrass
suggested changes
Feb 25, 2021
src/handle_vote.cxx
Outdated
Comment on lines
80
to
84
| bool ok = pp->recreate_rpc(s_config, *ctx_); | ||
| if (ok) { | ||
| pp->set_free(); | ||
| pp->set_manual_free(); | ||
| } |
There was a problem hiding this comment.
Seems that every time recreate_rpc() call success, set_free() and set_manual_free() must be called. Better call them inside recreate_rpc() before return true.
There was a problem hiding this comment.
Makes sense, thanks.
src/raft_server.cxx
Outdated
Comment on lines
896
to
900
| bool ok = p.recreate_rpc(s_config, *ctx_); | ||
| if (ok) { | ||
| p.set_free(); | ||
| p.set_manual_free(); | ||
| } |
There was a problem hiding this comment.
same as previous comment
| @@ -209,10 +209,12 @@ void peer::recreate_rpc(ptr<srv_config>& config, | |||
| // A reconnection attempt should be treated as an activity, | |||
| // hence reset timer. | |||
| reset_active_timer(); | |||
| return true; | |||
There was a problem hiding this comment.
better call set_free() and set_manual_free() here?
yong-li
approved these changes
Feb 26, 2021
greensky00
added a commit
to greensky00/NuRaft
that referenced
this pull request
Mar 14, 2021
* This happens due to recent protocol change: eBay#182
greensky00
added a commit
that referenced
this pull request
Mar 14, 2021
* This happens due to recent protocol change: #182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support offline data change (including snapshot installation),
peer's log info should be reset if the previous connection is gone.
Otherwise, there will be a data mismatch and the leader will attempt
to send logs based on incorrect info.
The reset peer info will be recovered during the first
append_entriescommunication between the leader and the peer.