Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log output #290

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Fix log output #290

merged 2 commits into from
Feb 27, 2022

Conversation

JackyWoo
Copy link
Contributor

Found an overflow int32 logging.

2 nodes (out of 3, 3 including learners) are not responding longer than 10000 ms, at least 1645066963648514 node        s (including leader) should be alive to proceed commit

@JackyWoo
Copy link
Contributor Author

Maybe it is not a good way or logging because too easy to miss match type.

@greensky00
Copy link
Contributor

Can you fix other formats in the same log as well?

        p_er("%d nodes (out of %d, %zu including learners) are not "
             "responding longer than %d ms, "
             "at least %d nodes (including leader) should be alive "
             "to proceed commit",

Copy link
Contributor

@greensky00 greensky00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greensky00 greensky00 merged commit 6925f4f into eBay:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants