Avoid config change to be lost. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Aug 29, 2019
src/handle_join_leave.cxx
Outdated
| p_in( "Try to add server %d. But now there is a " | ||
| "un-committed config change. Should wait. " | ||
| "Count: %d.", srv_to_join_->get_id(), count++); | ||
| std::this_thread::sleep_for |
There was a problem hiding this comment.
Hi @shigui1989 , sleeping inside Asio worker threads looks to me not good.
How about maintaining intermediate_config_ separate to config_? That contains the latest config that is not committed yet. And we make new_conf based on that intermediate_config_, not config_. Also we need to update intermediate_config_ properly here, and clear it in reconfigure() function maybe. Then we can avoid the situation that multiple uncommitted configs overwrite each other.
Please let me know if you want to make this change by yourself, or I can do it on this PR. Thanks.
There was a problem hiding this comment.
Yes. You can help. Please go ahead! Thanks.
greensky00
approved these changes
Aug 30, 2019
alesapin
added a commit
to alesapin/NuRaft
that referenced
this pull request
Jan 22, 2022
…atch Fix bug which lead to memory leak (cherry picked from commit 1707a75)
JackyWoo
pushed a commit
to JackyWoo/NuRaft
that referenced
this pull request
Sep 30, 2022
…atch Fix bug which lead to memory leak
xiaoxichen
pushed a commit
to xiaoxichen/NuRaft
that referenced
this pull request
Jan 16, 2024
SDSTOR-xxxx bump sisl to v9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.