fix calc_sever print_status npe bug #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greensky00
reviewed
Nov 21, 2022
CMakeLists.txt
Outdated
Comment on lines
88
to
95
| include_directories(BEFORE | ||
| /usr/local/opt/openssl/include | ||
| /opt/homebrew/opt/[email protected]/include | ||
| ) | ||
| link_directories( | ||
| /usr/local/opt/openssl/lib | ||
| /opt/homebrew/opt/[email protected]/lib | ||
| ) |
There was a problem hiding this comment.
Can you please make a separate PR for this? There are two different fixes here. And also I recommend
if (APPLE)
execute_process(COMMAND brew --prefix OUTPUT_VARIABLE BREW_PREFIX)
message(STATUS "brew prefix ${BREW_PREFIX}")
include_directories(BEFORE
${BREW_PREFIX}/opt/[email protected]/include
/usr/local/opt/openssl/include
...
There was a problem hiding this comment.
You are right, I will do it later.
examples/calculator/calc_server.cxx
Outdated
Comment on lines
155
to
157
| << ((stuff.sm_->last_snapshot() != nullptr) ? stuff.sm_->last_snapshot()->get_last_log_idx() : 0) << std::endl | ||
| << "last snapshot log term: " | ||
| << stuff.sm_->last_snapshot()->get_last_log_term() << std::endl | ||
| << ((stuff.sm_->last_snapshot() != nullptr) ? stuff.sm_->last_snapshot()->get_last_log_term() : 0) << std::endl |
There was a problem hiding this comment.
Please break lines at 90 chars
Line 7 in 71c3340
Also it can be simplified as follows
(stuff.sm_->last_snapshot() ? stuff.sm_->last_snapshot()->get_last_log_idx() : 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、 fix ssl library path not found in my mac m1.
2、fix example npe bugs.