Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links: Update color #1904

Closed
randybascue opened this issue Oct 19, 2022 · 1 comment
Closed

Links: Update color #1904

randybascue opened this issue Oct 19, 2022 · 1 comment
Assignees
@LuLaValva
Labels
module: link priority: 3 Fix should be on roadmap or backlog type: feature
Milestone
15.2.0

Comments

@randybascue
Copy link

Links, including ebay-fake-link, should use foreground-primary instead of foreground-accent.

There are two variants, a standard inline and a standalone. Inline is the default and is always underlined. Standalone is used in cases where the context is heavily implied, like a link tree in the footer.
@randybascue
Copy link
Author

image

@agliga agliga added type: feature module: link priority: 3 Fix should be on roadmap or backlog labels Oct 19, 2022
@agliga agliga mentioned this issue Oct 20, 2022
Closed
@agliga agliga mentioned this issue Oct 20, 2022
Closed
@agliga agliga added this to the 15.2.0 milestone Oct 26, 2022
@LuLaValva LuLaValva mentioned this issue Nov 2, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuLaValva LuLaValva

Labels
module: link priority: 3 Fix should be on roadmap or backlog type: feature
Projects
None yet
Milestone
15.2.0
Development

No branches or pull requests
3 participants
@agliga @LuLaValva @randybascue