Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link): update color to foreground-primary #1920

Merged
merged 3 commits into from
Nov 7, 2022
Merged

feat(link): update color to foreground-primary #1920

merged 3 commits into from
Nov 7, 2022

Conversation

LuLaValva
Copy link
Member

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Updated color to match design system

Notes

  • There is no specification for :visited links in the design system, so this PR retains the purple color for now.
  • Designs include a "standalone link," which may warrant the creation of a new class such as a.link--standalone. However, nav-link already matches the standalone designs so this addition may not be necessary.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@LuLaValva LuLaValva self-assigned this Nov 2, 2022
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good
One more change might be needed. When I open skin site, the menu looks like this:
Screen Shot 2022-11-03 at 9 10 05 AM

https://github.com/eBay/skin/blob/master/docs/src/less/breakpoints.less#L44-L46
We should probably set this to primary too

@LuLaValva
Copy link
Member Author

Thanks Andrew, didn't catch that on my end. Should be fixed now.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, but there is a visual regression issue that we should discuss privately.

@LuLaValva
Copy link
Member Author

As discussed offline, I have added the standalone-link class which is stylistically identical to nav-link. Examples did not seem necessary, but please let me know if you would like for me to add some to storybook and the skin site.

@agliga agliga merged commit e75342a into 15.2.0 Nov 7, 2022
@agliga agliga deleted the 1904-link branch November 7, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants