Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed deprecated code #1841

Merged
merged 1 commit into from
Aug 25, 2022
Merged

chore: removed deprecated code #1841

merged 1 commit into from
Aug 25, 2022

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Aug 23, 2022

Fixes #1650

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Removed the following deprecations (for release notes)

  • Removed multiple split icon packs
  • Removed wide button
  • Removed panel-dialog center
  • Removed lightbox-dialog--mini
  • Removed all bubble variables (bubble-base-box-shadow and such)
  • Removed dialog gutter size variables (@dialog-small-gutter-size @dialog-large-gutter-size)
  • Removed borderless expand-button/menu-button
  • Removed @button-padding-horizontal-wide

Notes

I did not remove expand button or window notice components yet. Those will be in a followup pr.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working on my end

@agliga agliga merged commit b1e3557 into 15.0.0 Aug 25, 2022
@agliga agliga deleted the deprecations branch August 25, 2022 16:20
agliga added a commit that referenced this pull request Aug 25, 2022
agliga added a commit that referenced this pull request Aug 25, 2022
ArtBlue pushed a commit that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants