Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated magenta 4 color and rebuilt #1926

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

martin-ebay
Copy link
Contributor

Fixes #1909

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

updating magenta 4

Notes

Screenshots

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga
Copy link
Contributor

agliga commented Nov 8, 2022

There's some deleted files in dist. Just verify running the build doesn't add them again.
I'm fine merging like that if those are gone in src.

@martin-ebay
Copy link
Contributor Author

@agliga there are large and small versions of the svgs that got deleted. I did a fresh build after nuking the dist folder locally.

@ArtBlue ArtBlue self-requested a review November 8, 2022 16:48
@ArtBlue
Copy link
Contributor

ArtBlue commented Nov 8, 2022

@martin-ebay , change the target branch to the skin repo 15.2.0.

@martin-ebay martin-ebay changed the base branch from master to 15.2.0 November 8, 2022 16:52
@martin-ebay
Copy link
Contributor Author

@ArtBlue updated the base branch. Looks like I don't have access to merge

@agliga agliga merged commit cad7087 into eBay:15.2.0 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token: color-magenta-4 is incorrect
3 participants