Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): fixed loading button form variant alignment #1960

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Dec 13, 2022

Fixes #1940

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Fixes the center alignment of loading button.

Screenshots

BEFORE
image

AFTER
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Dec 13, 2022
@agliga agliga mentioned this pull request Dec 13, 2022
9 tasks
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'll approve, but would like to know— there aren't any designs in Figma that suggest this now, if there is potential for more centered graphics like this in the future it might make sense to add a class for them so we don't duplicate all of this logic.

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Dec 13, 2022

Looks good!

I'll approve, but would like to know— there aren't any designs in Figma that suggest this now, if there is potential for more centered graphics like this in the future it might make sense to add a class for them so we don't duplicate all of this logic.

Possibly, but it's hard to anticipate that sort of thing. Also, requiring any sort of modifier for centering would be a breaking change.

@LuLaValva
Copy link
Member

Also, requiring any sort of modifier for centering would be a breaking change.

Oh, right. Yes, definitely leave it as it is then.

@ArtBlue ArtBlue merged commit 58be01f into 15.3.0 Dec 13, 2022
@ArtBlue ArtBlue deleted the 1940-loading-button-form-variant branch December 13, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants