chore(RTL): swapped left/right spacing with css logical properties #2158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1885
Description
This issue is for refactoring
margin-left/right
for RTL into logical properties ofmargin-inline-start/end
.Notes
Here are the details of the work with note. Some of the RTL blocks cannot be removed as they include RTL updates that cannot be accomplished with logical properties. For example, transform: rotate(180deg). Also, some of the files need more major refactored as they include a mix of margin-left, margin-right, absolute positioning with left and right. In other instances, the RTL mode is merely a fix to address some edge case that the LTR mode doesn’t need to address.
The following modules have some notes on exceptions of refactoring:
.page-notice__footer
needs more substantial work to align/simplify things..section-notice__footer
andsection-notice__cta
need more substantial work to align/simplify things.Screenshots
Checklist