Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ai gradient icons #2168

Merged
merged 2 commits into from
Oct 11, 2023
Merged

feat: added ai gradient icons #2168

merged 2 commits into from
Oct 11, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Oct 2, 2023

Fixes #2149

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added support for gradient icons which have nested defs

Notes

Here are the following changes that needed to be done to get this to work

  • Pulled out all defs from icons. Added those in an array in the script
  • Appended those to the top of the global icons.svg sheet as defs tag
  • Now, this would work fine as is, but there is a chrome bug where an external file does not pull in the defs. In order to get around this, we need to embed the SVG file in the top of the docs page. So I added a way to copy the svg file to an html file and then include that in the root of the skin docs. I also added a style to hide it in the top of the page.
  • Some other files were modified. There was a typo I fixed in the scripts which had height spelled as heightt.

Screenshots

Screenshot 2023-10-02 at 12 23 45 PM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Oct 2, 2023
@agliga agliga force-pushed the ai-gradient-icons branch from 0a06cd7 to bdd027d Compare October 2, 2023 19:38
scripts/generate-images.js Outdated Show resolved Hide resolved
docs/src/less/index.less Show resolved Hide resolved
scripts/generate-images.js Outdated Show resolved Hide resolved
scripts/generate-images.js Show resolved Hide resolved
dist/icon/icon.css Outdated Show resolved Hide resolved
@agliga
Copy link
Contributor Author

agliga commented Oct 4, 2023

Should be ready for rereview @ArtBlue

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@agliga agliga merged commit 68411be into 16.8.0 Oct 11, 2023
@agliga agliga deleted the ai-gradient-icons branch October 11, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants