Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility: fixed image right-click suppression #2181

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Oct 11, 2023

Fixes #2068

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • I fixed image right click suppression with the method suggested in the issue.
  • I also added a notes section under Utility with the first note about the performance impact of will-change.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Percy and Storybook are N/A above.

@ArtBlue ArtBlue self-assigned this Oct 11, 2023
@ArtBlue ArtBlue merged commit 8f57a30 into 16.8.0 Oct 11, 2023
@ArtBlue ArtBlue deleted the 2068-utility-image-treatment-fixes branch October 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants