Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): added flags #2190

Merged
merged 5 commits into from
Oct 26, 2023
Merged

feat(flags): added flags #2190

merged 5 commits into from
Oct 26, 2023

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Oct 24, 2023

Fixes #2184

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

This PR contains following changes,

  • Added the new Flag SVG assets
  • Created the flag generation script to add flag- prefixes to all flags that are not prefixed already.
  • Updated Skin docs.
  • Added flag stories to storybook

Notes

  • Even though creating a new script (flag generation) violated DRY, imo it's better to separate the icons and flags script as flags is more one time execution script.
  • Should we add the attribution to flag-icons?
  • There is an unknown flag. Should we keep it?
  • Should we restrict min/max widths for these flags?

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@saiponnada saiponnada linked an issue Oct 24, 2023 that may be closed by this pull request
@saiponnada saiponnada changed the base branch from master to 16.9.0 October 24, 2023 19:50
@saiponnada saiponnada self-assigned this Oct 24, 2023
@saiponnada saiponnada added this to the 16.9.0 milestone Oct 24, 2023
@saiponnada saiponnada marked this pull request as ready for review October 24, 2023 22:18
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@saiponnada saiponnada merged commit b754a24 into 16.9.0 Oct 26, 2023
2 checks passed
@saiponnada saiponnada deleted the 2184-new-module-flags branch October 26, 2023 17:32
@saiponnada saiponnada removed this from the 16.9.0 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

New Module: Flags
2 participants