Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progress-stepper): updated font-size to be default #2194

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(progress-stepper): updated font-size to be default #2194

merged 1 commit into from
Nov 9, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Oct 30, 2023

Fixes #2176

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • We were overriding the font size for small screens (my guess is this was the old design). Removed those old overrides.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

saiponnada
saiponnada approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agliga agliga merged commit 8fc533e into 16.9.0 Nov 9, 2023
@agliga agliga deleted the stepper-font branch November 9, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuLaValva LuLaValva LuLaValva approved these changes

@saiponnada saiponnada saiponnada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agliga @saiponnada @LuLaValva