Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(combobox): add blue focus indicator #2207

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 14, 2023

Fixes #2201

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Removed outline 0 from combobox

Screenshots

Screenshot 2023-11-14 at 2 52 08 PM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Nov 14, 2023
Copy link
Contributor

@ianmcburnie ianmcburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to review whether we still want to retain the old custom focus indicator as well. But at least this is consistent with textbox behavior for now.

border-color: var(--combobox-textbox-focus-border-color, var(--color-foreground-primary));

@ianmcburnie ianmcburnie merged commit 5262309 into 16.9.0 Nov 17, 2023
@ianmcburnie ianmcburnie deleted the combobox-outline branch November 17, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants