Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(icons): icon additions and modifications #2221

Merged
merged 2 commits into from
Dec 5, 2023
Merged

chore(icons): icon additions and modifications #2221

merged 2 commits into from
Dec 5, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Dec 5, 2023

Fixes #2166

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added new icons and updated some current ones.

Notes

There were a couple of bugs - a bad conditional and a missing line in package.json that I addressed.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Dec 5, 2023
agliga
agliga approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks for adding that line in package.json

@ArtBlue ArtBlue merged commit 992a79d into 17.0.0 Dec 5, 2023
2 checks passed
@ArtBlue ArtBlue deleted the 2166-icon-updates branch December 5, 2023 17:47
ArtBlue added a commit that referenced this pull request Dec 27, 2023
@ArtBlue
chore(icons): icon additions and modifications (#2221)
d6f28be
agliga pushed a commit that referenced this pull request Dec 28, 2023
@ArtBlue @agliga
chore(icons): icon additions and modifications (#2221)
9d34fcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@ianmcburnie ianmcburnie Awaiting requested review from ianmcburnie

@saiponnada saiponnada Awaiting requested review from saiponnada

@LuLaValva LuLaValva Awaiting requested review from LuLaValva

Assignees

@ArtBlue ArtBlue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtBlue @agliga