fix(listbox-button): removed truncation #2229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2228
Description
(In this case I simply changed the html and saw that it stretched until infinite).
However when we changed it to be
inline-grid
frominline-flex
the truncation was picked up and we ended up with this bug where the listbox dropdown is aligned to the size of the button.So removing the truncation on the value solved this issue. We should probably revisit this in the future and put a limit on the container (a max width), but we need to get buy in from design. This is mostly to unblock teams that run into this issue with the last version.
Screenshots
Checklist