Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(listbox-button): removed truncation #2229

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(listbox-button): removed truncation #2229

merged 1 commit into from
Dec 12, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Dec 12, 2023

Fixes #2228

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • So when verifiying older versions of the listbox code on skin site, I noticed that overflow is set but was not doing anything in those versions.
    (In this case I simply changed the html and saw that it stretched until infinite).
Screenshot 2023-12-12 at 8 22 38 AM

However when we changed it to be inline-grid from inline-flex the truncation was picked up and we ended up with this bug where the listbox dropdown is aligned to the size of the button.

So removing the truncation on the value solved this issue. We should probably revisit this in the future and put a limit on the container (a max width), but we need to get buy in from design. This is mostly to unblock teams that run into this issue with the last version.

Screenshots

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Dec 12, 2023
@agliga agliga merged commit f4b5df1 into master Dec 12, 2023
@agliga agliga deleted the listbox-strech branch December 12, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listbox-button: does not stretch container
3 participants