Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skeletons): incorrect block margins #2242

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix(skeletons): incorrect block margins #2242

merged 2 commits into from
Jan 12, 2024

Conversation

saiponnada
Copy link
Contributor

Fixes #2239

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

This change fixes skeletons having default top margins. Instead adds spacing to block level elements after the first one.

Screenshots

Before
image
After
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@saiponnada saiponnada self-assigned this Jan 5, 2024
LuLaValva
LuLaValva reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, just a quick comment. Also, can we rebase 17.1.0 with master before merging this?

src/less/skeleton/skeleton.less Outdated Show resolved Hide resolved
ArtBlue
ArtBlue approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@saiponnada saiponnada merged commit b1052f1 into 17.1.0 Jan 12, 2024
@saiponnada saiponnada deleted the skeleton-fix branch January 12, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuLaValva LuLaValva LuLaValva left review comments

@agliga agliga agliga approved these changes

@ArtBlue ArtBlue ArtBlue approved these changes

@ianmcburnie ianmcburnie Awaiting requested review from ianmcburnie

Assignees

@saiponnada saiponnada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saiponnada @ianmcburnie @ArtBlue @agliga @LuLaValva