Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textbox,listbox-button): add icon to error messages #2247

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jan 10, 2024

Fixes #2103

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added an icon to the left of the error messages (aka descriptions of error type) to listbox button and textbox.

Notes

This feature branch was branch from the companion branch (2063-listbox-error-state) to inherit some necessary preliminary work. This PR requires the merging of #2063 before it can rebase/merge from 17.1.0 to allow for completion.

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Jan 10, 2024
@ArtBlue ArtBlue marked this pull request as ready for review January 12, 2024 14:36
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, one minor issue.

dist/field/field.css Outdated Show resolved Hide resolved
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArtBlue ArtBlue merged commit c0555ad into 17.1.0 Jan 19, 2024
1 check passed
@ArtBlue ArtBlue deleted the 2103-textbox-listbox-error-icon branch January 19, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants