Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatar): updated colors #2250

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat(avatar): updated colors #2250

merged 1 commit into from
Jan 18, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 12, 2024

Fixes #2204

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Swapped colors with new colors

Notes

  • Since there is no official colors yet, I added them as private less variables (prefix with underscore). This way when we get the new colors we can remove them and it won't be breaking.
  • Since these did not have any dark mode variants these are the same colors used in dark mode.

Screenshots

Screenshot 2024-01-12 at 11 43 59 AM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@agliga agliga merged commit 447338b into 17.1.0 Jan 18, 2024
2 checks passed
@agliga agliga deleted the avatar-color branch January 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants