docs(skeleton): reworked examples #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtBlue
reviewed
Jan 18, 2024
saiponnada
previously approved these changes
Jan 18, 2024
agliga
previously approved these changes
Jan 18, 2024
saiponnada
reviewed
Jan 18, 2024
Co-authored-by: Arthur Khachatryan <[email protected]> Co-authored-by: Goutham Ponnada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE SQUASH
Description
These are documentation changes only for the skeleton examples. Best way to review this is to pull it down locally, run it and read through it and view each example.
Please focus on narrative and nature of examples. Look for factual errors or anything that might be confusing/unclear.
Please do not focus on the example CSS and JS. It's quick and dirty and we can clean that up if we feel the need.
I decided to remove the frames as I didn't feel like they added anything. I do feel that we might want to go back and reformat and make things a little prettier at some point.