Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fixed responsive menu #2288

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 12, 2024

Fixes #2287

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Fixed the responsive menu for small screens.

Notes

I forced the visited link color to be inline with the default state as menu/submenu item links are typically exempt from the typical visited link color changes in content body.

Screenshots

Before

Light
Screenshot 2024-03-12 at 10 51 33 AM

Dark
Screenshot 2024-03-12 at 1 42 13 PM


After

Light
Screenshot 2024-03-12 at 10 51 41 AM

Dark
Screenshot 2024-03-12 at 1 42 35 PM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Mar 12, 2024
Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: a3e69c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, Looks good to me. A minor question.

docs/src/less/index.less Outdated Show resolved Hide resolved
@ArtBlue ArtBlue merged commit 71cb87d into 17.3.0 Mar 13, 2024
1 check passed
@ArtBlue ArtBlue deleted the 2287-docs-fix-responsive-menu branch March 13, 2024 17:03
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants