tokens: added tokens, colors, deprecations #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 64b3c61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agliga
reviewed
Jun 22, 2024
| @@ -6,7 +6,7 @@ $color-star-rating-icon-unfilled-foreground: transparent; | |||
| $color-star-rating-icon-filled-foreground: var(--color-foreground-primary); | |||
|
|
|||
| /* we have to use core color here since dark mode and light mode have the same stroke */ | |||
| $color-star-rating-icon-unfilled-stroke: var(--color-neutral-5); | |||
| $color-star-rating-icon-unfilled-stroke: var(--color-neutral-600); | |||
There was a problem hiding this comment.
Should we switch these to semantic tokens possibly?
There was a problem hiding this comment.
There's a comment right above that regarding the decision to use the core token instead of the semantic token.
|
Approving, but lets wait for other PRs to merge before merging this. |
agliga
approved these changes
Jun 24, 2024
|
I think we're good to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2243
Description
New tokens, color revisions, color family deprecations and removals.
Screenshots
Checklist