Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tourtip): improve contrast of tip container #2440

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

saiponnada
Copy link
Contributor

Fixes #2416

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Updated tokens to use color-background-inverse for background and color-foreground-on-inverse for foreground color.
  • Fixed the spacing between fake link and CTA button

Notes

  • tourtip__index currently inherits the color of the container but will be replaced with the foreground-secondary-on-inverse once DS defines it.
  • An open issue where focus ring is not visible in dark mode which will be fixed with enhancement Update Buttons to Design Spec  #2421

Screenshots

image

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@saiponnada saiponnada self-assigned this Sep 11, 2024
Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 1ea265e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saiponnada saiponnada merged commit 9ca9bd3 into 18.3.0 Sep 13, 2024
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
@agliga agliga deleted the tourtip-changes branch September 28, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants