Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(list): added bulleted list and reordered fieldset examples #2499

Closed
wants to merge 2 commits into from

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 21, 2024

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added bulleted list example
  • Moved fieldset example to the bottom

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

@agliga agliga requested a review from ianmcburnie November 21, 2024 16:33
@agliga agliga self-assigned this Nov 21, 2024
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: cfd407d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

src/modules/list.marko Show resolved Hide resolved
@ianmcburnie
Copy link
Contributor

ianmcburnie commented Nov 22, 2024

So, I noticed something else. In VoiceOver none of the list semantics are being announced. I believe this is a Safari "feature", when list-style is removed it also removes the semantics (sigh). A solution in the past was always to add role=list onto the ul/ol, but it seems there might be a better way now:

https://medium.com/@havard.brynjulfsen/removing-list-style-on-lists-and-the-accessibility-implications-that-follow-2392f5ddb332

@ianmcburnie ianmcburnie mentioned this pull request Nov 22, 2024
9 tasks
@ArtBlue ArtBlue marked this pull request as draft November 22, 2024 21:46
@ArtBlue
Copy link
Contributor

ArtBlue commented Nov 22, 2024

Converting this to a draft PR.

As agreed offline to the following:

  1. We'll hold off on these changes for this release.
  2. Remove <ol> docs from 18.5.0.
  3. Add in the <ol> docs here for a holistic solution with <ul>.
  4. Target this for 19.0.0.

@agliga agliga deleted the branch 18.5.0 December 16, 2024 18:40
@agliga agliga closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants