Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added component meta tags #2534

Merged
merged 1 commit into from
Jan 22, 2025
Merged

chore(docs): added component meta tags #2534

merged 1 commit into from
Jan 22, 2025

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jan 21, 2025

Fixes #2411

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added meta tags for components -

  1. So they display meaningful titles in browser tabs.
  2. So they get indexed properly in search engines.

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 765a15a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thoughts on maybe putting all the DS metadata in each of these? Can be in follow up.

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Jan 22, 2025

LGTM, thoughts on maybe putting all the DS metadata in each of these? Can be in follow up.

Sounds like an interesting idea, but would we duplicate them or move them? I wouldn't want to duplicate, if possible, and I believe DS needs the centralized metadata for Figma. If we did do it, it would probably need to be a coordinated effort of some sort.

These meta files will also be getting many more meta tags for use, such as the component image for display when the component URL is shared on a social media platform.

@ArtBlue ArtBlue merged commit d8f88b5 into 19.0.0 Jan 22, 2025
@ArtBlue ArtBlue deleted the 2411-add-meta-tags branch January 22, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants