Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combobox): remove chevron from combobox #2537

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

LuLaValva
Copy link
Member

Fixes #

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Removes chevron from examples for combobox and chips-combobox to reduce confusion on it being an input and not a dropdown

Notes

Screenshots

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
luehm Alex Luehm
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 44a1065

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit b6f7744 into 19.0.0 Jan 27, 2025
@agliga agliga deleted the combobox-remove-chevron branch January 27, 2025 18:04
This was referenced Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants