Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketsans): upgraded font implementing market sans v2 #2575

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Feb 18, 2025

Fixes #2574

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  1. Uploaded Market Sans v2 font set (regular and bold) to CDN inside https://ir.ebaystatic.com/cr/v/c1/market-sans/v2.0/
  2. Integrated Market Sans v2 into Skin
  3. Implemented Market Sans v2 throughout library
  4. Made some minor adjustments to docs
  5. Verified the vertical spacing of the v2 font addresses various spacing issues throughout, most notoriously for avatar.

Notes

The Market Sans font css files probably need to be updated to remove some legacy stuff. For now, I kept them as they are to avoid making bigger ripples than necessary.

Since the font adjustment has likely created a large set of diffs, I will run the visual regression tests in the release branch prior to the release.

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I verify the markup will not be a breaking change (if not a major release)
  • I verify the MIND pattern for the component has been created/revised
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: ea2bea9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Seems to be working on my end, and avatar is vertically aligned without hacks 😁

@ArtBlue ArtBlue merged commit 89cdc3a into 19.1.0 Feb 18, 2025
@ArtBlue ArtBlue deleted the 2574-use-market-sans-v2 branch February 18, 2025 22:18
This was referenced Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants