Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding when an appendable structure contains a mutable structure [20045] #180

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

richiware
Copy link
Member

No description provided.

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix decoding when an appendable structure contains a mutable structure Fix decoding when an appendable structure contains a mutable structure [20045] Nov 27, 2023
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks

test/xcdr/appendable.cpp Outdated Show resolved Hide resolved
fastcdr.repos Outdated Show resolved Hide resolved
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Ricardo González Moreno <[email protected]>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@JLBuenoLopez
Copy link
Contributor

@richiprosima please test windows

@JLBuenoLopez
Copy link
Contributor

Windows CI: SUCCESSFUL

@richiware richiware merged commit 381592a into master Nov 29, 2023
8 of 9 checks passed
@richiware richiware deleted the bugfix/20044 branch November 29, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants