-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use assign for deserialize instead of temporary std::string #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
requested changes
Oct 10, 2024
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
assign
branch
from
December 17, 2024 08:22
7ce2d74
to
5dd3c1c
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
December 17, 2024 08:24
Signed-off-by: Samuel Hyyppä <[email protected]>
MiguelCompany
force-pushed
the
assign
branch
from
December 17, 2024 08:36
5dd3c1c
to
33dce6d
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
December 17, 2024 08:36
MiguelCompany
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@SamuelH91 Thank you for your contribution and patience! |
@Mergifyio backport 1.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Signed-off-by: Samuel Hyyppä <[email protected]> Co-authored-by: Samuel Hyyppä <[email protected]> (cherry picked from commit 5b8025b) # Conflicts: # include/fastcdr/Cdr.h # include/fastcdr/FastCdr.h
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At deserialize of fixed_string (cdr) or string (fastcdr) temporary std::string was used which may allocate memory dynamically, which is not desirable or needed especially if using fixed_strings.
@Mergifyio backport 1.0.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist