Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/xml standard [4115] #352

Merged
merged 16 commits into from
Jan 8, 2019
Merged

Feature/xml standard [4115] #352

merged 16 commits into from
Jan 8, 2019

Conversation

coquisx
Copy link
Contributor

@coquisx coquisx commented Dec 12, 2018

Adapted xmlparser to standard DDSXTypes

@coquisx coquisx changed the title Feature/xml standard Feature/xml standard [#4115] Dec 12, 2018
@ghost ghost requested a review from LuisGP December 12, 2018 09:33
@ghost ghost assigned LuisGP Dec 12, 2018
LuisGP
LuisGP approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@LuisGP LuisGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update XML Types section in Fast-RTPS-docs.

LGTM

LuisGP
LuisGP suggested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@LuisGP LuisGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement pending TODO parts

src/cpp/xmlparser/XMLParser.cpp Outdated Show resolved Hide resolved
LuisGP
LuisGP previously approved these changes Dec 12, 2018
View reviewed changes
LuisGP
LuisGP previously approved these changes Dec 12, 2018
View reviewed changes
@richiware richiware changed the title Feature/xml standard [#4115] Feature/xml standard [4115] Dec 13, 2018
jorgeboza and others added 12 commits January 3, 2019 16:04
Refs #4026 Adapted xmlparser to standard DDS-XTypes and added xml exa…
45037b0 
…mple
Refs #4026 Reformatted text
99e2df4
Refs #4026 Included key for datatypes
05894ee
Refs #4026 Deleted old syntax allowed
420665c
Refs #4026 Fix mane of config file for dynamicTest
e73f805
Refs #4026 Introduced cases to string and wstring in getDiscriminator…
f5428b6 
…TypeBuilder
Refs #4026 Fix cases of bounded string and bounded wstring, in alias …
962015f 
…definitions and members definitions
Refs #4026 Added two new test for bounded string and bounded wstring
141b684
Refs #4026 Modified config file for dynamictype test
6a6ed9d
Refs #4127. Update XSD file and change part of the parser to be more …
2de9c46 
…restrictive
Refs #4127 Review the XML Parser to be more restrictive
480868a
Refs #4108 Update the parser of durations and locators with the new s…
5ee131c 
…tructures.
@LuisGP LuisGP force-pushed the feature/xml_standard branch from 4f1cf59 to 585c63b Compare January 3, 2019 15:25
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware richiware merged commit 846307b into develop Jan 8, 2019
@richiware richiware deleted the feature/xml_standard branch January 8, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

@LuisGP LuisGP LuisGP left review comments

Assignees

@richiware richiware

@MiguelCompany MiguelCompany

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coquisx @richiware @LuisGP @MiguelCompany @JuanCarlos-Arce