New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/udp closing with whitelist [4427] #387

Merged

richiware merged 6 commits into develop from hotfix/udp_closing_with_whitelist

Jan 24, 2019

Contributor

LuisGP commented Jan 23, 2019

Solves #4420

LuisGasco added 2 commits

January 23, 2019 10:28


          Refs #4420 Added thread to retry closing input channels.

14a5650


          Refs #4276 Added blackbox tests to test discovery using only multicast.

7429ec8

LuisGP changed the title ~~Hotfix/udp closing with whitelist~~ Hotfix/udp closing with whitelist [4427]


          Refs #4420 Removed thread and disabling all related channels before r…

4f34f93

…eleasing them.

LuisGP force-pushed the hotfix/udp_closing_with_whitelist branch from ea2a7a9 to 4f34f93 Compare

January 23, 2019 09:58

Member

richiware commented Jan 23, 2019

Build status:

Linux
Mac
Windows


          Refs #4420 Avoiding access already closed endpoints on Windows.

78c09a5

richiware requested changes

View reviewed changes

src/cpp/transport/UDPTransportInterface.cpp

                       mInputSockets.erase(IPLocator::getPhysicalPort(locator));
                   }
-                  for (auto* channelResource : pChannelResources)
+                  std::map<UDPChannelResource*, asio::ip::address> addresses;
+                  // It may sound redundant, but we must mark all the related channel to be killed first.

Member

richiware Jan 23, 2019

Improve this comment.


          Refs #4420 Improved comments.

bea84ca

Member

richiware commented Jan 23, 2019

Build status:

Linux
Mac
Windows

richiware approved these changes

View reviewed changes


          Merge branch 'develop' into hotfix/udp_closing_with_whitelist

bf7b637

Member

richiware commented Jan 24, 2019

Build status:

Linux
Mac
Windows

richiware merged commit 92386bd into develop

richiware deleted the hotfix/udp_closing_with_whitelist branch

January 24, 2019 14:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet