Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20502] TCP non_blocking_send moved to TCPTransportDescriptor #4415

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[20502] TCP non_blocking_send moved to TCPTransportDescriptor #4415

merged 2 commits into from
Feb 28, 2024

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Feb 21, 2024 •
edited by EduPonz
Loading

Description

Previously, the non_blocking_send mode for TCP was set as a non-consolidated QoS. It will now be configured as an attribute of the TCPTransportDescriptor.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: eProsima/Fast-DDS-docs [20502] TCP non_blocking_send moved to TCPTransportDescriptor Fast-DDS-docs#678
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jepemi jepemi added this to the v2.14.0 milestone Feb 21, 2024
@MiguelCompany MiguelCompany changed the title [20502} TCP non_blocking_send moved to TCPTransportDescriptor [20502] TCP non_blocking_send moved to TCPTransportDescriptor Feb 21, 2024
@jepemi jepemi mentioned this pull request Feb 21, 2024
Merged
@cferreiragonz cferreiragonz mentioned this pull request Feb 23, 2024
Merged
11 tasks
@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed first-to-merge labels Feb 26, 2024
@jepemi jepemi force-pushed the feature/tcp_non_blocking_send_to_descriptor branch from 37b0c48 to fded5e5 Compare February 28, 2024 10:02
MiguelCompany
MiguelCompany approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed labels Feb 28, 2024
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 28, 2024
@EduPonz EduPonz merged commit 1c82f83 into master Feb 28, 2024
11 of 17 checks passed
@EduPonz EduPonz deleted the feature/tcp_non_blocking_send_to_descriptor branch February 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
first-to-merge ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jepemi @MiguelCompany @EduPonz @JesusPoderoso