Adding pdf posts #19
Open
Adding pdf posts #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myucekul
reviewed
Aug 14, 2024
submit_pubs_v2.py
Outdated
| params=params, | ||
| files={'file': pdf_response.content}) | ||
|
|
||
| if media_response.status_code > 300: |
There was a problem hiding this comment.
We should save the response code in DB in case of failure too.
submit_pubs_v2.py
Outdated
| osti_pub['response_success'] = True | ||
| osti_pub['osti_id'] = osti_pub['response_json']['osti_id'] | ||
|
|
||
| # If metadata submission was successful, submit the PDF | ||
| media_response = submit_media(osti_creds, osti_pub) | ||
| if media_response is False: |
There was a problem hiding this comment.
How would the failed media submissions be retried?
There was a problem hiding this comment.
We have a few options -- can discuss at 1:1
* Added eschol db logging fields needed for resubmission checking. * Added working update .sql files * Datetime formatting aligned btw MSSQL and MYSQL * Refactoring creds to env; splitting out metadata and pdf updates * Various metadata cleanups; program restructuring continues * Separated v1 in the main run function * General code cleanup * Revisions for using media_id instead of media_file_id for PDF resubmission
|
@myucekul -- Code updates from this week have been pulled into this adding-pdf-posts branch: |
myucekul
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.