Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow starting remotebmi containers #467

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Allow starting remotebmi containers #467

merged 7 commits into from
Nov 27, 2024

Conversation

BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Nov 22, 2024

This PR adds support for remotebmi.

The arguments between grpc4bmi and remotebmi differ subtlety, so I had to add an extra "protocol" property to the eWaterCycle Model class.

eg:

RemoteBMIModel(eWaterCycleModel):
    bmi_image: ContainerImage("ghcr.io/ewatercycle/ewatercycle-walrus:latest")
    protocol= "openapi"
...

@BSchilperoort BSchilperoort marked this pull request as ready for review November 27, 2024 10:49
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.92%. Comparing base (258cd7f) to head (f66a4a0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ewatercycle/container.py 21.42% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   79.32%   78.92%   -0.41%     
==========================================
  Files          28       28              
  Lines        1862     1874      +12     
  Branches      155      159       +4     
==========================================
+ Hits         1477     1479       +2     
- Misses        327      336       +9     
- Partials       58       59       +1     
Files with missing lines Coverage Δ
src/ewatercycle/base/model.py 97.31% <100.00%> (+0.01%) ⬆️
src/ewatercycle/container.py 66.31% <21.42%> (-3.52%) ⬇️

@BSchilperoort BSchilperoort merged commit a4bddc9 into main Nov 27, 2024
5 of 6 checks passed
@BSchilperoort BSchilperoort deleted the remotebmi branch November 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant