Add missing omitempty (flyteorg#347)

Signed-off-by: Ketan Umare <[email protected]>
eapolinario · Oct 21, 2021 · 37408ed · 37408ed
1 parent 486632d
commit 37408ed
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/node_status.go b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/node_status.go
@@ -36,8 +36,8 @@ func (in MutableStruct) IsDirty() bool {
 
 type BranchNodeStatus struct {
 	MutableStruct
-	Phase           BranchNodePhase `json:"phase"`
-	FinalizedNodeID *NodeID         `json:"finalNodeId"`
+	Phase           BranchNodePhase `json:"phase,omitempty"`
+	FinalizedNodeID *NodeID         `json:"finalNodeId,omitempty"`
 }
 
 func (in *BranchNodeStatus) GetPhase() BranchNodePhase {
@@ -96,7 +96,7 @@ const (
 
 type DynamicNodeStatus struct {
 	MutableStruct
-	Phase  DynamicNodePhase `json:"phase"`
+	Phase  DynamicNodePhase `json:"phase,omitempty"`
 	Reason string           `json:"reason,omitempty"`
 	Error  *ExecutionError  `json:"error,omitempty"`
 }
@@ -158,8 +158,8 @@ const (
 
 type WorkflowNodeStatus struct {
 	MutableStruct
-	Phase          WorkflowNodePhase    `json:"phase"`
-	ExecutionError *core.ExecutionError `json:"executionError"`
+	Phase          WorkflowNodePhase    `json:"phase,omitempty"`
+	ExecutionError *core.ExecutionError `json:"executionError,omitempty"`
 }
 
 func (in *WorkflowNodeStatus) SetExecutionError(executionError *core.ExecutionError) {
@@ -186,7 +186,7 @@ func (in *WorkflowNodeStatus) SetWorkflowNodePhase(phase WorkflowNodePhase) {
 
 type NodeStatus struct {
 	MutableStruct
-	Phase                NodePhase     `json:"phase"`
+	Phase                NodePhase     `json:"phase,omitempty"`
 	QueuedAt             *metav1.Time  `json:"queuedAt,omitempty"`
 	StartedAt            *metav1.Time  `json:"startedAt,omitempty"`
 	StoppedAt            *metav1.Time  `json:"stoppedAt,omitempty"`
@@ -195,9 +195,9 @@ type NodeStatus struct {
 	Message              string        `json:"message,omitempty"`
 	DataDir              DataReference `json:"-"`
 	OutputDir            DataReference `json:"-"`
-	Attempts             uint32        `json:"attempts"`
+	Attempts             uint32        `json:"attempts,omitempty"`
 	SystemFailures       uint32        `json:"systemFailures,omitempty"`
-	Cached               bool          `json:"cached"`
+	Cached               bool          `json:"cached,omitempty"`
 
 	// This is useful only for branch nodes. If this is set, then it can be used to determine if execution can proceed
 	ParentNode    *NodeID                  `json:"parentNode,omitempty"`