Set store to read only after unpickling #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
Nov 21, 2024
| @@ -33,6 +34,7 @@ | |||
|
|
|||
| class IcechunkStore(Store, SyncMixin): | |||
| _store: PyIcechunkStore | |||
| _pickle_preserves_read_only: bool | |||
There was a problem hiding this comment.
I put this on this class, not PyIcechunkStore, since this is the one that handles pickling.
paraseba
approved these changes
Nov 21, 2024
| self._pickle_preserves_read_only = True | ||
| yield | ||
| finally: | ||
| self._pickle_preserves_read_only = False |
There was a problem hiding this comment.
shouldn't this be the previous value of the variable instead?
There was a problem hiding this comment.
it's always only modified in this method, so the previous value is always False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383
xref #185