Require opt-in to pickling writable Sessions and Stores. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
requested review from
mpiannucci and
paraseba
and removed request for
mpiannucci
dcherian
commented
Jan 31, 2025
| if allow_pickling: | ||
| with session.allow_pickling(): | ||
| to_icechunk(data, store=session.store, mode="w") | ||
| with xr.open_zarr(session.store, consolidated=False) as ds: |
There was a problem hiding this comment.
this is not so nice now.
The distributed-read piece needs to be within the context manager now, because we can't (easily) set read-only status when unpickling. We could do so I think, by creating a brand new Session with branch=None. Let's discuss tomorrow..
This is uglier than it used to because we cannot deserialize to a read-only Session or Store by default anymore. Well we could, but it would take some extra work. Closes #478 xref #185 (comment)
dcherian
force-pushed
the
pickling-error
branch
from
83fbda1 to
0d96c8b
Compare
paraseba
reviewed
Jan 31, 2025
paraseba
approved these changes
Jan 31, 2025
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Feb 4, 2025
…d IcechunkStore following earth-mover/icechunk#652
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Feb 4, 2025
…d IcechunkStore following earth-mover/icechunk#652 (#688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is uglier than it used to because we cannot deserialize to a read-only Session or Store by default anymore.
Well we could, but it would take some extra work.
I can add some docs once #633 goes in
Closes #478
xref #185 (comment)