Add debug information #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
approved these changes
Oct 17, 2024
cheran-senthil
approved these changes
Oct 17, 2024
|
Let's maybe not log the S3 URL, that seems like info a user shouldn't have |
jlmonroy13
force-pushed
the
eng-217/add-debug-information
branch
from
5300061 to
ac59b62
Compare
jlmonroy13
added a commit
that referenced
this pull request
Oct 17, 2024
* Download from s3 to decrypt * Use secret value directly * Remove test logging * Add yarn * Add debug information (#25) --------- Co-authored-by: Dheeraj Manjunath <[email protected]> Co-authored-by: Jorge Luis Monroy Herrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
https://linear.app/earthfast/issue/ENG-217/add-debug-information-to-dashboard-runner
Screenshot