Enable JSON output for all blockchain commands #22

the-flagship · 2022-11-03T03:04:14Z

This PR enables the oclif-builtin --json flag for all blockchain commands.

An explicit choice was made to do if (!flags.json) console.log(output) instead of using this.log("%O", output) because the latter loses coloring, which is kinda sad.

Example UX enabled by this change:

$ armada reservation list $(armada project list --owner=0xF62e<snip> --size=1 --json | jq -r .[0].id) --json | jq .[].host
"content3.usw2.testnet.armadanodes.com"
"content3.use2.testnet.armadanodes.com"

src/commands/node/list.ts

the-masthead · 2022-11-03T06:35:57Z

src/commands/reservation/create.ts

@@ -37,14 +37,16 @@ export default class ReservationCreate extends TransactionCommand {
    const prices = nodeIds.map(() => parseUnits("1", 18));
    CliUx.ux.action.start("- Submitting transaction");
    const slot = { last: !!flags.spot, next: !flags.norenew };
-    console.log([projectId, nodeIds, prices, slot]);


Thanks for removing this rogue debug log!

Enable JSON output for all blockchain commands

bca0e6a

the-flagship requested a review from the-masthead November 3, 2022 03:04

the-masthead approved these changes Nov 3, 2022

View reviewed changes

Don't double-normalize

6dd2272

the-flagship merged commit 536d1cb into main Nov 3, 2022

the-flagship deleted the json-flag branch November 3, 2022 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable JSON output for all blockchain commands #22

Enable JSON output for all blockchain commands #22

the-flagship commented Nov 3, 2022

the-masthead Nov 3, 2022

Enable JSON output for all blockchain commands #22

Enable JSON output for all blockchain commands #22

Conversation

the-flagship commented Nov 3, 2022

the-masthead Nov 3, 2022

Choose a reason for hiding this comment