Add reasonable defaults #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-flagship
requested changes
Nov 7, 2022
src/commands/node/list.ts
Outdated
Comment on lines
34
to
37
| (((!flags.spot && !flags.renew) || v.projectIds[0] === HashZero || v.projectIds[1] === HashZero) && | ||
| ((flags.spot && flags.renew) || (v.projectIds[0] === HashZero && v.projectIds[1] === HashZero)) && | ||
| ((!flags.spot && flags.renew) || v.projectIds[0] === HashZero) && | ||
| ((flags.spot && !flags.renew) || v.projectIds[1] === HashZero)) |
There was a problem hiding this comment.
Think we could convert these to english and include as a comment above each line?
There was a problem hiding this comment.
Good point, see if this is clearer.
the-masthead
force-pushed
the
defaults
branch
from
d5cb3ac to
0da8131
Compare
the-masthead
force-pushed
the
defaults
branch
from
0da8131 to
3a5698a
Compare
the-flagship
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.