Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-227] Rename to use Earthfast contracts #83

Merged
merged 6 commits into from
Nov 7, 2024
Merged

[ENG-227] Rename to use Earthfast contracts #83

merged 6 commits into from
Nov 7, 2024

Conversation

dmanjunath
Copy link
Contributor

No description provided.

MikeHathaway
MikeHathaway approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - missing one reference to ARMADA for the symbol on line 76 of helpers.ts

@MikeHathaway
Copy link
Contributor

We should also probably remove the depracated /abi/staging and /abi/testnet directories

@dmanjunath dmanjunath marked this pull request as ready for review November 7, 2024 20:01
@dmanjunath dmanjunath merged commit 31570fa into main Nov 7, 2024
@dmanjunath dmanjunath deleted the dm-rename-armada branch November 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmanjunath @MikeHathaway